D23067: Clean up usage of m_client

[Roman Gilg]

romangg added a comment.


  In D23067#510334 <https://phabricator.kde.org/D23067#510334>, @gladhorn wrote:
  
  > I hope this is now making the code slightly easier to read, without changing the functionallity, except for shuffling things around a tiny bit where we discussed. It also adds a few extra checks, to play safe with the smart pointers. These nullptr checks are extremely cheap.
  
  
  I would still like to omit them for code sanity. Checking things just to be sure pollutes the code rather easily and makes it difficult to read. If there is no parallelism in play we can say for sure if something exists or not at a certain point in time. Having decided the wrong way and then fixing it afterwards is better long-term than putting superfluous checks just to be sure.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23067

To: gladhorn, #kwin
Cc: romangg, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190811/f0295aeb/attachment.html>