D23086: Be consistent about touch point id type: Qt uses qint32
Roman Gilg
noreply at phabricator.kde.org
Sun Aug 11 15:08:01 BST 2019
romangg added a comment.
In D23086#510314 <https://phabricator.kde.org/D23086#510314>, @zzag wrote:
> Someone "fixed" these warnings a while ago, but you reverted the fix.
I know. I reverted because it broke functionality. So there was no fix.
>> This makes sense because libinput provides (non-negative) int32 ids/slots.
>
> Even if it makes sense, the warnings have to be fixed. Comparing signed and unsigned numbers without taking extra measures is bad.
"This makes sense" as in this fix here. If libinput would provide uint32 ids it would not make sense.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D23086
To: gladhorn, #kwin
Cc: zzag, romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190811/43f49698/attachment-0001.html>
More information about the kwin
mailing list