D23085: Make iterating over Layer enum simple

Frederik Gladhorn noreply at phabricator.kde.org
Sun Aug 11 15:02:34 BST 2019


gladhorn marked an inline comment as done.
gladhorn added a comment.


  In D23085#510297 <https://phabricator.kde.org/D23085#510297>, @zzag wrote:
  
  > > to iterate over the enum, is mostly confusing
  >
  > I actually find it a bit cool because we're iterating through layers, but yeah this part can be simpler. :-)
  
  
  Yes, I was amused as well, but to understand what is going on I had to read code in two places instead of one.

INLINE COMMENTS

> zzag wrote in layers.cpp:536
> You don't need this static_cast.

Nice, of course :)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23085

To: gladhorn, #kwin, romangg, zzag
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190811/08d5b19e/attachment.html>


More information about the kwin mailing list