D23069: Remove disabled TabGroup feature

Roman Gilg noreply at phabricator.kde.org
Sun Aug 11 00:03:31 BST 2019


romangg added a subscriber: zzag.
romangg added a comment.


  Wow, didn't thought it would be that much abandoned code. I'm definitely now for removing all of it. Even if we find the time to bring tabbed windows back at some point in the future it will probably be easier to just start again from scratch. And with this commit we can then still consult the old code for inspiration.
  
  So +1, current version also approved by @zzag?

INLINE COMMENTS

> client.cpp:1615
> -        if (isCurrentTab())
> -            FocusChain::self()->update(this, FocusChain::MakeLast);
>          addWorkspaceRepaint(visibleRect());

`isCurrentTab` is without tabs always true, right? So then this should be kept.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23069

To: gladhorn, #kwin
Cc: zzag, romangg, graesslin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190810/aa1a98c1/attachment.html>


More information about the kwin mailing list