D22973: docs: introduce commit message guideline

Vlad Zagorodniy noreply at phabricator.kde.org
Sat Aug 10 17:21:38 BST 2019


zzag added inline comments.

INLINE COMMENTS

> romangg wrote in HACKING.md:161
> The "Breaking Changes" was copied over from the Angular guide lines, but maybe we should remove it here. For once because we don't really have defined what breaking changes are in KWin. Is a change to the Effects API/ABI a breaking change? Is a behavioral change for users one?

We can drop this section as we check libkwineffects API version.

> Is a change to the Effects API/ABI a breaking change?

Third-party effects need to be recompiled if API version of libkwineffects is bumped. It's a good idea to compile your third-party effect against each major release of KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22973

To: romangg, #kwin
Cc: davidedmundson, yurchor, anthonyfieroni, zzag, ngraham, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190810/22e6cf1f/attachment-0001.html>


More information about the kwin mailing list