D23070: Remove usage of QWeakPointer for QObject for thumbnails
Frederik Gladhorn
noreply at phabricator.kde.org
Sat Aug 10 15:25:49 BST 2019
gladhorn added a comment.
In D23070#509774 <https://phabricator.kde.org/D23070#509774>, @romangg wrote:
> Ok, I believe I got it now. The QWeakPointer constructer should get either passed a QSharedPointer or QWeakPointer as argument. But here we just pass the QObject EffectWindowImpl. Thanks for explaining.
Indeed, QWeakPointer should only come from QSharedPointer, nothing else.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D23070
To: gladhorn, #kwin, romangg
Cc: romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190810/898ed959/attachment.html>
More information about the kwin
mailing list