D23067: Clean up usage of m_client

Vlad Zagorodniy noreply at phabricator.kde.org
Sat Aug 10 10:13:08 BST 2019


zzag added a comment.


  Besides braces this patch looks good.

INLINE COMMENTS

> useractions.cpp:151-152
>      if (y == pos.top()) {
> -        m_client.data()->blockActivityUpdates(true);
> +        if (m_client)
> +            m_client->blockActivityUpdates(true);
>          if (needsPopup) {

Use curly braces even when the body of a conditional statement contains only one line.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23067

To: gladhorn, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190810/5f5e8213/attachment.html>


More information about the kwin mailing list