D22973: docs: introduce commit message guideline
Roman Gilg
noreply at phabricator.kde.org
Thu Aug 8 10:34:35 BST 2019
romangg added inline comments.
INLINE COMMENTS
> HACKING.md:161
> +
> +**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.
The "Breaking Changes" was copied over from the Angular guide lines, but maybe we should remove it here. For once because we don't really have defined what breaking changes are in KWin. Is a change to the Effects API/ABI a breaking change? Is a behavioral change for users one?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D22973
To: romangg, #kwin
Cc: zzag, ngraham, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190808/ba5574ff/attachment-0001.html>
More information about the kwin
mailing list