D22894: Rename "Desktop Effects" to "Graphical Effects"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, KWin.
Herald added projects: KWin, Documentation.
Herald added subscribers: kde-doc-english, kwin.
ngraham requested review of this revision.

REVISION SUMMARY
  KWin's Desktop Effects suffer from the following UI issues:
  
  - Inappropriate use of the word "Desktop." In the typical user's understanding, the desktop is the thing with a wallpaper and icons on it.
  - Inconsistent terminology: mostly called "desktop effects", but the string "Window manager effects" is used in knsrc
  - Inconsistent terminology between the KCM name, comment, and title
  
  This patch resolves all three issues by using the more accurate term "Graphical Effects", and using it consistently, with appropriate sentence-style tooltips.
  
  Because KWin maintainers have indicated in D14561 <https://phabricator.kde.org/D14561> that in circumstances like this, all instances of a string should be changed, I have changed the string in the backend as well, not only for the user interface.

TEST PLAN
  F7141156: Effects.png <https://phabricator.kde.org/F7141156>

REPOSITORY
  R108 KWin

BRANCH
  desktop-to-graphical (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22894

AFFECTED FILES
  composite.cpp
  doc/kwineffects/index.docbook
  doc/kwinscreenedges/index.docbook
  doc/kwintabbox/index.docbook
  doc/windowspecific/index.docbook
  kcmkwin/common/effectsmodel.cpp
  kcmkwin/kwincompositing/kwincompositing.desktop
  kcmkwin/kwineffects/kcm.cpp
  kcmkwin/kwineffects/kcm_kwin_effects.desktop
  kcmkwin/kwineffects/kwineffect.knsrc
  kcmkwin/kwineffects/package/contents/ui/main.qml
  kcmkwin/kwineffects/package/metadata.desktop
  kcmkwin/kwintabbox/main.ui
  options.h
  plugins/scenes/opengl/scene_opengl.cpp

To: ngraham, #vdg, #kwin
Cc: kwin, kde-doc-english, LeGast00n, fmonteiro, sbergeron, jraleigh, gennad, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190802/74b3f760/attachment-0001.html>