French translation breaks KStars build

[Albert Astals Cid]

El dilluns, 23 d’octubre de 2023, a les 19:28:13 (CEST), Yoann Laissus va 
escriure:
> Hello,
> 
> Thanks Albert for fixing it.
> 
> In the french team, we are using a recent kdoctools version for building
> docbooks (as part of the merging / scattering process).
> It's unfortunately causing issues with older kdoctools, sorry for that. CI
> images and versions seem to vary a lot depending on the projects.
> 
> To avoid problems like that, what's the recommended version of kdoctools
> (and other i18n tools) to use in our scripts ?

As you have already discovered minimum required versions vary a lot depending 
on the project so there's not really a recommended version other than "the one 
that each project requires" i guess if you want to play it safe, it'd be "the 
minimum all projects require", but I'm not sure we have a way of knowing which 
version is that at any given point in time.

> I guess it might also be necessary in the future to use different
> kdoctools versions between kf5 / kf6 docbooks ?

Yes, need to use the KF6 version of kdoctools for apps that are KF6 based.

Cheers,
  Albert

> 
> Cheers,
> 
> Le lun. 23 oct. 2023 à 01:04, Hy Murveit <murveit at gmail.com> a écrit :
> > It looks like the French translation has broken the KStars build, so we
> > can't submit.
> > Please have a look at the recent changes.
> > 
> > Thanks,
> > Hy
> > 
> > https://invent.kde.org/education/kstars/-/jobs/1268419
> > 
> > -- Build files have been written to: /builds/education/kstars/kstars-build
> > 350 <https://invent.kde.org/education/kstars/-/jobs/1268419#L350>$ ninja
> > -j8 all install
> > 351 <https://invent.kde.org/education/kstars/-/jobs/1268419#L351>[1/726]
> > Generating ts...
> > 352 <https://invent.kde.org/education/kstars/-/jobs/1268419#L352>[2/726]
> > Generating po/fr/docs/kstars/index.cache.bz2
> > 353 <https://invent.kde.org/education/kstars/-/jobs/1268419#L353>FAILED:
> > po/fr/docs/kstars/index.cache.bz2
> > /builds/education/kstars/kstars-build/po/fr/docs/kstars/index.cache.bz2
> > 354 <https://invent.kde.org/education/kstars/-/jobs/1268419#L354>cd
> > /builds/education/kstars && /usr/bin/meinproc5 --check --cache
> > /builds/education/kstars/kstars-build/po/fr/docs/kstars/index.cache.bz2
> > po/fr/docs/kstars/index.docbook
> > 355
> > <https://invent.kde.org/education/kstars/-/jobs/1268419#L355>fitsviewer.d
> > ocbook:324: parser error : Entity 'Shift' not defined
> > 356 <https://invent.kde.org/education/kstars/-/jobs/1268419#L356>
> > 
> > >&Shift;<keycap
> > 
> > 357 <https://invent.kde.org/education/kstars/-/jobs/1268419#L357> ^
> > 358
> > <https://invent.kde.org/education/kstars/-/jobs/1268419#L358>fitsviewer.d
> > ocbook:794: parser error : chunk is not well balanced
> > 359 <https://invent.kde.org/education/kstars/-/jobs/1268419#L359>^
> > 360
> > <https://invent.kde.org/education/kstars/-/jobs/1268419#L360>tools.docboo
> > k:79: parser error : Entity 'tool-fitsviewer' failed to parse
> > 361 <https://invent.kde.org/education/kstars/-/jobs/1268419#L361>r;
> > &tool-solarsys; &tool-ekos; &tool-jmoons; &tool-obsplanner;
> > &tool-fitsviewer;
> > 362 <https://invent.kde.org/education/kstars/-/jobs/1268419#L362> ^
> > 363
> > <https://invent.kde.org/education/kstars/-/jobs/1268419#L363>tools.docboo
> > k:80: parser error : chunk is not well balanced
> > 364 <https://invent.kde.org/education/kstars/-/jobs/1268419#L364>^
> > 365
> > <https://invent.kde.org/education/kstars/-/jobs/1268419#L365>index.docboo
> > k:397: parser error : Entity 'tools' failed to parse
> > 366 <https://invent.kde.org/education/kstars/-/jobs/1268419#L366>&tools;
> > <!--&kstars; Tools-->
> > 367 <https://invent.kde.org/education/kstars/-/jobs/1268419#L367> ^
> > 368
> > <https://invent.kde.org/education/kstars/-/jobs/1268419#L368>kf.doctools.
> > core: Error: `xmllint --noout` outputted text
> > 369 <https://invent.kde.org/education/kstars/-/jobs/1268419#L369>[3/726]
> > Generating po/pt_BR/docs/kstars/index.cache.bz2
> > 370 <https://invent.kde.org/education/kstars/-/jobs/1268419#L370>I/O
> > warning : failed to load external entity
> > "/usr/share/kf5/kdoctools/customization/xsl/pt-BR.xml"
> > 371 <https://invent.kde.org/education/kstars/-/jobs/1268419#L371>No
> > "pt_br" localization of "footer-doc-comment" exists; using "en".
> > 
> > On Mon, Aug 28, 2023 at 1:08 PM Albert Astals Cid <aacid at kde.org> wrote:
> >> El dissabte, 26 d’agost de 2023, a les 21:26:31 (CEST), Hy Murveit va
> >> 
> >> escriure:
> >> > Shouldn't the translation commit fail if the compile fails (like most
> >> 
> >> other
> >> 
> >> > commits)? If that were the case then issues such as this wouldn't break
> >> 
> >> the
> >> 
> >> > KStars build.
> >> 
> >> Sadly the amount of translation commits that we do every day makes it not
> >> really scalable to compile them all before commiting.
> >> 
> >> Cheers,
> >> 
> >>   Albert
> >>   
> >> > On Sat, Aug 26, 2023, 12:22 PM Johnny Jazeix <jazeix at gmail.com> wrote:
> >> > > Hi;,
> >> > > I fixed it, the usual issue of using entities that have been added in
> >> > > kdoctools 5.95 and kstars compiling with a 5.92 version.
> >> > > 
> >> > > Cheers,
> >> > > Johnny
> >> > > 
> >> > > 
> >> > > Le mer. 9 août 2023 à 07:52, Jasem Mutlaq <mutlaqja at ikarustech.com> a
> >> > > 
> >> > > écrit :
> >> > > > Hello,
> >> > > > 
> >> > > > Build log: https://invent.kde.org/education/kstars/-/jobs/1107308
> >> > > > 
> >> > > > Can you please check?
> >> > > > 
> >> > > > --
> >> > > > Best Regards,
> >> > > > Jasem Mutlaq