Build is broken in 3.6.7 without CFitsio

[Jasem Mutlaq]

THank you for the report. cfitsio is optional, I can confirm the issue. Hy
added ImageOverlayComponent in 3.6.8 that includes fitsdata. So we either
disable this component when cfitsio is not detected, or we enable it but as
an #ifdef around line imageoverlaycomponent.cpp line 392

--
Best Regards,
Jasem Mutlaq



On Tue, Dec 19, 2023 at 12:45 AM Albert Astals Cid <aacid at kde.org> wrote:

> Please CC me I'm not on the list.
>
>
>
> You can see the log here
>
> https://buildbot.flathub.org/api/v2/logs/3498660/raw
>
> CFitsio is marked as not found
>
> -- The following OPTIONAL packages have not been found:
>
>  * CFitsio, FITS IO Library, <https://heasarc.gsfc.nasa.gov/fitsio/
> fitsio.html <https://heasarc.gsfc.nasa.gov/fitsio/fitsio.html>>
>    Support for the FITS (Flexible Image Transport System) data format in
> KStars.
>
>
> but then it's tried to be used anyway.
>
>
> /run/build/kstars/kstars/fitsviewer/fitsdata.h:33:10: fatal error:
> fitsio.h:
> No such file or directory
>    33 | #include <fitsio.h>
>
>
> What is the fix? Should CFitsio be made mandatory? Or is there a way to
> make
> it compile without it?
>
> Cheers,
>   Albert
>
> Please CC me I'm not on the list.
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20231219/46eb496a/attachment.htm>