re "Only Start if Guide Deviation <" feature

[Hy Murveit]

Wolfgang,

I don't think Alfred has it quite right, but here's my shot at what might
be wrong.

In order for the pre-capture guide check to be
enforced, prepareActions[ACTION_GUIDER_DRIFT] needs to be set to false.
As far as I can tell, during capture execution it is only set to false
in SequenceJobState::prepareLightFrameCapture in sequencejobstate.cpp line
50
I believe that prepareLightFrameCapture is only called at the start of a
job, and not before each capture, since:

   - it is only called by SequenceJob::prepareCapture()
   - which is called only by Capture::preparePreCaptureActions()
   - which is called by both Capture::scriptFinished (I'm ignoring that,
   doesn't seem relevant) and Capture::prepareActiveJobStage2()
   - which is called by both Capture::scriptFinished (I'm ignoring that,
   doesn't seem relevant) and Capture::prepareActiveJobStage1()
   - which is only called by Capture::prepareJob

and from its title, prepareJob() sounds like it is only called at the start
of a job, not each individual capture.

Perhaps the bug is that there should be an else at this line:
https://invent.kde.org/education/kstars/-/blob/master/kstars/ekos/capture/sequencejobstate.cpp#L722
e.g.
else prepareActions[ACTION_GUIDER_DRIFT] = false;

Hy

On Thu, Aug 18, 2022 at 3:32 PM amiga2000c at gmx.de <amiga2000c at gmx.de> wrote:

>
> Despite the fact that I have absolutely no clue about C++, I had a look
> at the code. I think the relevant piece is "capture.cpp".
>
> A passage where 10 checks are being performed (6039-6121) before
> "everything is ready for capturing light frames" cought my attention.
>
>
> Step 6 is check guide deviation. Assuming guiding was suspended and the
> last measured guiding deviation was below the limit, this check is passed.
> Step 10 is check if guiding was suspended. If so, it is restarted and
> according to the comment it is assumed that "everything is ready for
> capturing light frames" then.
>
> IMO this is not the case. After resuming guiding, the "check guide
> deviation" test must be initiated again and only if it is passed,
> "everything is ready for capturing light frames", indeed.
>
> --
>
> In case what I wrote is complete rubbish, please excuse my clueless
> comment and ignore it.
>
> Regards
> Alfred
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20220818/07d90bf1/attachment.htm>