Critical Focus module bug

[Jasem Mutlaq]

Focus module was working quite well in 3.5.1 and before, but I think all
the changes since then have introduced this regression.

--
Best Regards,
Jasem Mutlaq



On Mon, Feb 8, 2021 at 1:41 PM Jasem Mutlaq <mutlaqja at ikarustech.com> wrote:

> Hello Eric,
>
> Actually, this has to do with Focus::checkStopFocus() ... IIRC, this was
> added by Hy to prevent some crash when doing HFR calculations?
>
> --
> Best Regards,
> Jasem Mutlaq
>
>
>
> On Mon, Feb 8, 2021 at 1:37 PM Eric Dejouhanet <eric.dejouhanet at gmail.com>
> wrote:
>
>> Yes this is the point of one of my draft MRs awaiting testing in the obs.
>> The autofocus / in focus is restarting until the retries have been
>> exceeded. The module is a mess of parallel management of ui and errors and
>> we're slowly getting through.
>>
>> eric.dejouhanet at gmail.com - https://astronomy.dejouha.net
>> *De:* mutlaqja at ikarustech.com
>> *Envoyé:* 8 février 2021 11:35
>> *À:* kstars-devel at kde.org
>> *Cc:* eric.dejouhanet at gmail.com
>> *Objet:* Critical Focus module bug
>>
>> Hello Eric,
>>
>> Please check the focus module, now if you click "Stop" when autofocus is
>> running, it just keeps going. I will check from my side, but I believe it's
>> due to your latest changes to the module. It even restarts on its own after
>> 20-30 secs after I clicked STOP!
>>
>> --
>> Best Regards,
>> Jasem Mutlaq
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20210208/50524ec7/attachment.htm>