How to make a PR. EKOS PAA with non-Goto mounts
Sebastian Neubert
se.neubert at gmail.com
Fri Feb 1 18:18:27 GMT 2019
Hi Jasem,
I have created a Differential with my changes:
https://phabricator.kde.org/D18650
I did not know which reviewers to add, could you please have a look?
Thanks,
Sebastian
On Fri, Feb 1, 2019 at 5:50 PM Sebastian Neubert <se.neubert at gmail.com>
wrote:
> Dear Jasem,
>
> thanks a lot! I'll have a look at Phabricator and come back to you if
> I have any questions.
>
> Cheers,
> Sebastian
>
> On Fri, Feb 1, 2019 at 4:24 PM Jasem Mutlaq <mutlaqja at ikarustech.com>
> wrote:
>
>> Hello Sebastian,
>>
>> Welcome to KStars! Thank you for your work, this feature was requested by
>> many.
>>
>> KDE uses Phabricator to manage code reviews. You can follow the guide
>> here:
>>
>> https://community.kde.org/Infrastructure/Phabricator
>>
>> If you find this overwhelming, you can just run a diff against master and
>> send me the patch. I'll review it myself and let you know of any issues.
>>
>> --
>> Best Regards,
>> Jasem Mutlaq
>>
>>
>>
>> On Fri, Feb 1, 2019 at 6:11 PM Sebastian Neubert <se.neubert at gmail.com>
>> wrote:
>>
>>> Dear KStars developers,
>>>
>>> following a discussion on the INDI forum (
>>> https://www.indilib.org/forum/ekos/3700-missing-manual-rotate-in-alignment-in-2-9-7.html)
>>> I have coded a solution that allows to use the polar alignment assistant in
>>> EKOS to be used with manual mounts. For details and screenshots see the
>>> thread linked above.
>>>
>>> I wanted to ask how we should proceed. Can I just push my branch to
>>> git://anongit.kde.org/kstars.git ?
>>> What is the best way to make a PR?
>>>
>>> If you have suggestions for changes to the feature, please let me know.
>>>
>>> Thanks a lot,
>>> Sebastian
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20190201/fd39a771/attachment.html>
More information about the Kstars-devel
mailing list