Review Request 113936: [GCI] Remove "No Equipment" option from settings dialog in "What's Interesting"

Jasem Mutlaq mutlaqja at ikarustech.com
Mon Jan 23 06:01:16 UTC 2017



> On Jan. 22, 2017, 10:19 p.m., Albert Astals Cid wrote:
> > This patch doesn't apply anymore. Anyone knows if it's because it was commited and then fixed up or because it was forgotten to be commited and needs updating?

Yeah this is inapplicable, please discard/close review request.


- Jasem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113936/#review102201
-----------------------------------------------------------


On Nov. 19, 2013, 5:47 p.m., Jai  Luthra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113936/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 5:47 p.m.)
> 
> 
> Review request for KStars and Samikshan Bairagya.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> GCI TASK: Remove "No Equipment" from settings dialog for What's Interesting feature.
> https://www.google-melange.com/gci/task/view/google/gci2013/5783794355273728
> 
> 
> Diffs
> -----
> 
>   kstars/kstars.kcfg a545dd8 
>   kstars/kstarsactions.cpp 1ed783e 
>   kstars/tools/whatsinteresting/wiequipsettings.h 24ec59b 
>   kstars/tools/whatsinteresting/wiequipsettings.cpp 84214ab 
>   kstars/tools/whatsinteresting/wiequipsettings.ui ba137e5 
> 
> Diff: https://git.reviewboard.kde.org/r/113936/diff/
> 
> 
> Testing
> -------
> 
> Compiles and runs as expected.
> 
> 
> Thanks,
> 
> Jai  Luthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20170123/4f9a3935/attachment.html>


More information about the Kstars-devel mailing list