Review Request 110971: Disable "Automatically select coordinate grid" when the user manually toggles equatorial or horizontal coordinate grids.

Aneesh Dogra lionaneesh at gmail.com
Sun Feb 26 00:53:22 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110971/
-----------------------------------------------------------

(Updated Feb. 26, 2017, 12:53 a.m.)


Status
------

This change has been marked as submitted.


Review request for KStars.


Bugs: 321027
    http://bugs.kde.org/show_bug.cgi?id=321027


Repository: kstars


Description
-------

I think if the user is asking to display the equatorial/horizontal grid we should just disable "Automatically select coordinate grid" and do what he wants. I don't really think disabling the buttons or showing the user a warning of some sort is the correct solution to this issue. Its like saying "Hey user you asked Kstars to automatically set the coordinate grids for you, but now you are yourself fiddling with the settings, that's not good, please go do 1, 2, 3". I am open to discussions, though. Thanks for taking time to review this.


Diffs
-----

  kstars/kstarsactions.cpp 1ed783e 

Diff: https://git.reviewboard.kde.org/r/110971/diff/


Testing
-------


Thanks,

Aneesh Dogra

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20170226/801a9812/attachment.html>


More information about the Kstars-devel mailing list