Review Request 128523: Fix regression where INDI version check is ignored.

Michael Palimaka kensington at gentoo.org
Wed Sep 21 15:47:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128523/
-----------------------------------------------------------

(Updated Sept. 21, 2016, 3:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and KStars.


Changes
-------

Submitted with commit bbd70f646ece7f512eb4964b8884aa399e002ed2 by Michael Palimaka to branch master.


Repository: kstars


Description
-------

40cf6ad6cd9a8773b78da828daf98069f4777d76 introduced a regression where any
version of INDI was accepted, even if it did not meet the minimum version
requirement.


Diffs
-----

  cmake/modules/FindINDI.cmake 1b7b43976e42b0ba310ed21006e3e8dab87790d6 

Diff: https://git.reviewboard.kde.org/r/128523/diff/


Testing
-------

INDI 1.1.0 is now ignored instead of build failing. Build still passes with INDI 1.2.0.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20160921/55dda5c2/attachment.html>


More information about the Kstars-devel mailing list