Review Request 129274: Fix compilation of fitsview.cpp for recent gcc

Jasem Mutlaq mutlaqja at ikarustech.com
Fri Oct 28 13:56:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129274/#review100363
-----------------------------------------------------------


Ship it!




Ship It!

- Jasem Mutlaq


On Oct. 28, 2016, 1:42 p.m., Christian Dersch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129274/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2016, 1:42 p.m.)
> 
> 
> Review request for KStars and Jasem Mutlaq.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Recent changes in fitsview.cpp break complilation with gcc >= 6, the patch fixes it by correctly calling std::abs() instead of ambiguous abs()
> 
> 
> Diffs
> -----
> 
>   kstars/fitsviewer/fitsview.cpp bd7ba58 
> 
> Diff: https://git.reviewboard.kde.org/r/129274/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Dersch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20161028/402d88bf/attachment.html>


More information about the Kstars-devel mailing list