Review Request 129387: [kstars] Fix build without indilib and cfitsio
Jasem Mutlaq
mutlaqja at ikarustech.com
Fri Nov 18 06:54:31 UTC 2016
> On Nov. 18, 2016, 12:39 a.m., Andreas Sturmlechner wrote:
> > You know, all I usually need is a Ship-it so I can push it myself. ;)
> >
> > Unfortunately, commit c29ef8466cdca80e4b1a34245a48dd3389e2b14f is not identical with my review, it is missing the last ifdef in kstars/options/opscolors.cpp
Sorry about that, it's fixed now.
- Jasem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129387/#review100921
-----------------------------------------------------------
On Nov. 13, 2016, 5:56 a.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129387/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2016, 5:56 a.m.)
>
>
> Review request for KStars.
>
>
> Repository: kstars
>
>
> Description
> -------
>
> Build was failing in two parts because of missing ifdefs.
>
>
> Diffs
> -----
>
> kstars/options/opscolors.cpp 8f6858444d2ceb029802a07430988098c1541467
> kstars/skycomponents/starblock.cpp 2a28ff23af0414f3b77cdc05fb6f893bc3254a4d
>
> Diff: https://git.reviewboard.kde.org/r/129387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20161118/210254ca/attachment.html>
More information about the Kstars-devel
mailing list