[Kstars-devel] Review Request 127116: Port What's Interesting tool to QML 2

[Jasem Mutlaq]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127116/#review94140
-----------------------------------------------------------



I get crash:

1	QXcbWindow::setParent(QPlatformWindow const *)			0x7fffe6858b38	
2	QWindow::setParent(QWindow *)			0x7ffff3e14f1b	
3	QWindowContainer::QWindowContainer(QWindow *, QWidget *, QFlags<Qt::WindowType>)			0x7ffff441f8e4	
4	QWidget::createWindowContainer(QWindow *, QWidget *, QFlags<Qt::WindowType>)			0x7ffff441fa11	
5	KStars::slotShowWIView	kstarsactions.cpp	477	0x736afc	
6	KStars::qt_static_metacall	moc_kstars.cpp	606	0x897c53	
7	QMetaObject::activate(QObject *, int, int, void * *)			0x7ffff3611f9a	
8	QDialog::finished(int)			0x7ffff45b87ce	
9	QDialog::done(int)			0x7ffff45b8f48	
10	QMetaObject::activate(QObject *, int, int, void * *)			0x7ffff3611e1f	
11	??			0x7ffff44e89c0	
12	QMetaObject::activate(QObject *, int, int, void * *)			0x7ffff3611f9a	
13	QAbstractButton::clicked(bool)			0x7ffff4759252	
14	??			0x7ffff44bbed4	
15	??			0x7ffff44bd4e9	
16	QAbstractButton::mouseReleaseEvent(QMouseEvent *)			0x7ffff44bd664	
17	QWidget::event(QEvent *)			0x7ffff4401f88	
18	QApplicationPrivate::notify_helper(QObject *, QEvent *)			0x7ffff43bf05c	
19	QApplication::notify(QObject *, QEvent *)			0x7ffff43c4c19	
20	QCoreApplication::notifyInternal(QObject *, QEvent *)			0x7ffff35e35bb	
...	<More>

- Jasem Mutlaq


On Feb. 26, 2016, 6:29 p.m., Artem Fedoskin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127116/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 6:29 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> 1. Changed roleNames() in SkyObjItem and SkyObjListModel to suit actual version of QAbstractListModel
> 2. Used KLocalizedContext instead of KDeclarative in tools/whatsinteresting/wiview.cpp on line 43. KLocalizedContext provides more convenient way to use i18n() and xi18n() in QML files. On my system (Kubuntu 15.10) I had to install libkf5i18n-dev from backports repository to get KLocalizedContext, but it is already listed in KDE API Documentation so I don't know why it is available only in backports repository. Use of KLocalizedContext is also good for future QML projects.
> 3. Changed custom scrolling ScrollBar to ScrollView from QtQuick.Controls, which provides platform’s native look and feel.
> 4. Changed deprecated QStandardPaths::DataLocation to QStandardPaths::AppDataLocation in file wiview.cpp.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2148e04 
>   kstars/CMakeLists.txt ef2227a 
>   kstars/kstars.h 39a7ad0 
>   kstars/kstars.cpp 73e590f 
>   kstars/kstarsactions.cpp aeef2fc 
>   kstars/kstarsinit.cpp e6af58a 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt a5ae3f8 
>   kstars/tools/whatsinteresting/qml/CategoryTitle.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/DetailsItem.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/wiview.qml f576ae0 
>   kstars/tools/whatsinteresting/skyobjitem.h ba163c4 
>   kstars/tools/whatsinteresting/skyobjitem.cpp de03829 
>   kstars/tools/whatsinteresting/skyobjlistmodel.h 17cfe4c 
>   kstars/tools/whatsinteresting/skyobjlistmodel.cpp a3c6519 
>   kstars/tools/whatsinteresting/wiview.cpp b05915e 
> 
> Diff: https://git.reviewboard.kde.org/r/127116/diff/
> 
> 
> Testing
> -------
> 
> Compiles and What's Interesting tool runs fine.
> 
> 
> Thanks,
> 
> Artem Fedoskin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20160330/6387576e/attachment.html>