[Kstars-devel] Review Request 127419: Fix build with -DQT_STRICT_ITERATORS

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127419/#review93689
-----------------------------------------------------------




kstars/auxiliary/qcustomplot.cpp (line 21439)
<https://git.reviewboard.kde.org/r/127419/#comment63878>

    Do we really need this? mData is a member variable and the function is const so the lowerBound called here should be the const variant, no?


- Albert Astals Cid


On March 18, 2016, 7:44 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127419/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 7:44 a.m.)
> 
> 
> Review request for KDE Edu and KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Avoid silent and implicit constness casts.
> 
> 
> Diffs
> -----
> 
>   kstars/auxiliary/qcustomplot.cpp 8d178be 
> 
> Diff: https://git.reviewboard.kde.org/r/127419/diff/
> 
> 
> Testing
> -------
> 
> Compilation tested.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20160318/f44cec10/attachment.html>