[Kstars-devel] Review Request 127116: Port What's Interesting tool to QML 2

[Jasem Mutlaq]

> On Feb. 21, 2016, 7:55 a.m., Jasem Mutlaq wrote:
> > Thanks a lot! I am still investigating KLocalizedContext, it seems it is not available in any official repo as you indicated. Maybe it got deprecated and they didn't update the API. Will inform you once I know what's going on.

So I contacted KLocalizedContext author and it is a new feature available in a recent release of KDE Frameworks so it is not yet available on most distros by default. We can include your patch in a branch for now until KF5 5.17+ becomes available on more distros.


- Jasem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127116/#review92602
-----------------------------------------------------------


On Feb. 19, 2016, 7:02 p.m., Artem Fedoskin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127116/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 7:02 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> 1. Changed roleNames() in SkyObjItem and SkyObjListModel to suit actual version of QAbstractListModel
> 2. Used KLocalizedContext instead of KDeclarative in tools/whatsinteresting/wiview.cpp on line 43. KLocalizedContext provides more convenient way to use i18n() and xi18n() in QML files. On my system (Kubuntu 15.10) I had to install libkf5i18n-dev from backports repository to get KLocalizedContext, but it is already listed in KDE API Documentation so I don't know why it is available only in backports repository. Use of KLocalizedContext is also good for future QML projects.
> 3. Changed custom scrolling ScrollBar to ScrollView from QtQuick.Controls, which provides platform’s native look and feel.
> 4. Changed deprecated QStandardPaths::DataLocation to QStandardPaths::AppDataLocation in file wiview.cpp.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2148e04 
>   kstars/CMakeLists.txt ef2227a 
>   kstars/kstars.h 39a7ad0 
>   kstars/kstars.cpp 73e590f 
>   kstars/kstarsactions.cpp aeef2fc 
>   kstars/kstarsinit.cpp e6af58a 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt a5ae3f8 
>   kstars/tools/whatsinteresting/qml/wiview.qml f576ae0 
>   kstars/tools/whatsinteresting/skyobjitem.h ba163c4 
>   kstars/tools/whatsinteresting/skyobjitem.cpp de03829 
>   kstars/tools/whatsinteresting/skyobjlistmodel.h 17cfe4c 
>   kstars/tools/whatsinteresting/skyobjlistmodel.cpp a3c6519 
>   kstars/tools/whatsinteresting/wiview.cpp b05915e 
> 
> Diff: https://git.reviewboard.kde.org/r/127116/diff/
> 
> 
> Testing
> -------
> 
> Compiles and What's Interesting tool runs fine.
> 
> 
> Thanks,
> 
> Artem Fedoskin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20160222/a00f1ff9/attachment.html>