[Kstars-devel] Review Request 123634: Proper observers management dialog job

Jasem Mutlaq mutlaqja at ikarustech.com
Tue May 5 06:52:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123634/#review79884
-----------------------------------------------------------


Great, except it is no longer "Add observer" but "Manage Observers". So Please update both the dialog name and the menu entry as well.

- Jasem Mutlaq


On May 4, 2015, 5:16 p.m., Daniel Leu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123634/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 5:16 p.m.)
> 
> 
> Review request for KStars and Jasem Mutlaq.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Implementation of a proper observer management dialog (Add/Remove/Edit possibilities).
> 
> 
> Diffs
> -----
> 
>   kstars/auxiliary/ksuserdb.h ccfc344 
>   kstars/auxiliary/ksuserdb.cpp 52d0c3a 
>   kstars/kstarsactions.cpp c990563 
>   kstars/oal/execute.h fed501d 
>   kstars/oal/execute.cpp 0a1c990 
>   kstars/oal/execute.ui ae9b866 
>   kstars/oal/observeradd.h 5e651ad 
>   kstars/oal/observeradd.cpp a52256f 
>   kstars/oal/observeradd.ui b67b3b9 
> 
> Diff: https://git.reviewboard.kde.org/r/123634/diff/
> 
> 
> Testing
> -------
> 
> Tested. It works.
> 
> 
> Thanks,
> 
> Daniel Leu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20150505/023a66f3/attachment.html>


More information about the Kstars-devel mailing list