[Kstars-devel] Review Request 122691: Porting WI tool to QML 2 and a few other changes

Jasem Mutlaq mutlaqja at ikarustech.com
Tue Mar 3 19:43:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122691/#review76966
-----------------------------------------------------------


Good job! Please keep on porting the WI tool to QML2 until it can be started up in KStars.

- Jasem Mutlaq


On March 3, 2015, 4:06 p.m., M.S. Adityan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122691/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 4:06 p.m.)
> 
> 
> Review request for KStars and Jasem Mutlaq.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Made a QML file called theme.qml, which has all the 'text properties' which can be reused many times. If what I am doing is right, then I can extend this idea to other properties.
> 
> 
> Diffs
> -----
> 
>   kstars/tools/whatsinteresting/qml/ScrollBar.qml 80160cb 
>   kstars/tools/whatsinteresting/qml/theme.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/wiview.qml f576ae0 
> 
> Diff: https://git.reviewboard.kde.org/r/122691/diff/
> 
> 
> Testing
> -------
> 
> KStars compiles fine on Kubuntu 14.10.
> 
> 
> Thanks,
> 
> M.S. Adityan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20150303/161894d5/attachment.html>


More information about the Kstars-devel mailing list