[Kstars-devel] Review Request 126532: KStars: A new HiDPI-ready world map image and logic for mapcanvas
Dmytro Shynkevych
dm.shynk at gmail.com
Sun Dec 27 00:06:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126532/
-----------------------------------------------------------
(Updated Dec. 27, 2015, 12:06 a.m.)
Review request for KStars and Andreas Cord-Landwehr.
Changes
-------
Chenged the image to the original version (should be public domain).
Repository: kstars
Description
-------
Now the world map is not pixelated on HiDPI settings anymore (with QT_DEVICE_PIXEL_RATIO up to 7.5, that is).
The image used is public domain, taken from here: http://www.westnet.com/~crywalt/unfold.html. It needs to be put in kstars/data (see the diff).
Diffs
-----
kstars/data/CMakeLists.txt 7c5724c
kstars/data/geomap.jpg PRE-CREATION
kstars/data/geomap.png 7dfd6f9
kstars/widgets/mapcanvas.cpp 79ad547
Diff: https://git.reviewboard.kde.org/r/126532/diff/
Testing
-------
Tested on my machine with QT_DEVICE_PIXEL_RATIO from 1 to 4, no regressions found.
However, clicking somewhat far from the original position (e.g. North America to Australia) is painfully slow. It is not a regression, as this exact behavior is present in the upstream code.
File Attachments (updated)
----------------
geomap.jpg
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/1924faa7-44f2-4b51-9891-fe531c6b4512__geomap.jpg
Thanks,
Dmytro Shynkevych
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20151227/1aa8d4a5/attachment.html>
More information about the Kstars-devel
mailing list