[Kstars-devel] Review Request 123515: Do not show another KMessageBox immediately after user clicked Cancel

Jasem Mutlaq mutlaqja at ikarustech.com
Mon Apr 27 12:49:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123515/#review79568
-----------------------------------------------------------

Ship it!


Ship It!

- Jasem Mutlaq


On April 27, 2015, 4:39 a.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123515/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 4:39 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> I think it is obvious to the user that the operation does not happen if
> you click Cancel. Thus, no additional message should be displayed.
> 
> 
> Diffs
> -----
> 
>   datahandlers/catalogdb.cpp 435442fdd15d7e1dd774bf7cd54bbe4149ff15de 
> 
> Diff: https://git.reviewboard.kde.org/r/123515/diff/
> 
> 
> Testing
> -------
> 
> I didn't test it. Hoping a one-liner change cannot break anything.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20150427/9777b963/attachment.html>


More information about the Kstars-devel mailing list