[Kstars-devel] Review Request 120090: This patch creates a offline version of supernovae.dat and updates data if net connection works

[Samikshan Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120090/#review65994
-----------------------------------------------------------



kstars/data/scripts/supernova_updates_parser.py
<https://git.reviewboard.kde.org/r/120090/#comment46082>

    Can you remove this trailing whitespace, which I never removed when I wrote this script. :)



kstars/data/scripts/supernova_updates_parser.py
<https://git.reviewboard.kde.org/r/120090/#comment46077>

    Could you use camel-case for the function name for more consistency? Otherwise, to satisfy Python purists, maybe remove camel-casing for all functions names.



kstars/data/scripts/supernova_updates_parser.py
<https://git.reviewboard.kde.org/r/120090/#comment46081>

    This needs to return an error-code when it is not possible to connect to the host. This error code will be caught in SupernovaeComponent::slotTriggerDataFileUpdate() method in kstars/skycomponents/supernovaecomponent.cpp and processed accordingly. When this script does not return any error code, the slot calling this python script gets an impression that there has been no issues while running the script.



kstars/data/supernovae.dat
<https://git.reviewboard.kde.org/r/120090/#comment46080>

    I think this file doesn't need to be added to kstars repository. When the user runs KStars with internet connectivity, this file will be generated.


- Samikshan Bairagya


On Sept. 7, 2014, 2:03 p.m., Sourav Moitra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120090/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 2:03 p.m.)
> 
> 
> Review request for KStars, Samikshan Bairagya and Sourav Moitra.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Fixed supernovae data fetch error while offline, I have added a new function in supernova_updates_parser.py which checks internet connection available or not if available it updates the supernovae data
> 
> 
> Diffs
> -----
> 
>   kstars/data/scripts/supernova_updates_parser.py 552e428 
>   kstars/data/supernovae.dat PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120090/diff/
> 
> 
> Testing
> -------
> 
> Visually inspecting,
> I have checked that and found that was working
> 
> 
> Thanks,
> 
> Sourav Moitra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140907/cea0b218/attachment.html>