[Kstars-devel] Review Request 120090: This patch creates a offline version of supernovae.dat and updates data if net connection works

[Rishab Arora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120090/#review65986
-----------------------------------------------------------



kstars/data/scripts/supernova_updates_parser.py
<https://git.reviewboard.kde.org/r/120090/#comment46073>

    Nit: Whitespace



kstars/data/scripts/supernova_updates_parser.py
<https://git.reviewboard.kde.org/r/120090/#comment46074>

    Should we check if http://www.cbat.eps.harvard.edu is available or not? It's possible www.google.com is up but harvard.edu isn't.


- Rishab Arora


On Sept. 7, 2014, 1:07 p.m., Sourav Moitra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120090/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 1:07 p.m.)
> 
> 
> Review request for KStars, Samikshan Bairagya and Sourav Moitra.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Fixed supernovae data fetch error while offline, I have added a new function in supernova_updates_parser.py which checks internet connection available or not if available it updates the supernovae data
> 
> 
> Diffs
> -----
> 
>   kstars/data/supernovae.dat PRE-CREATION 
>   kstars/data/scripts/supernova_updates_parser.py 552e428 
> 
> Diff: https://git.reviewboard.kde.org/r/120090/diff/
> 
> 
> Testing
> -------
> 
> Visually inspecting,
> I have checked that and found that was working
> 
> 
> Thanks,
> 
> Sourav Moitra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140907/ed0064b0/attachment.html>