[Kstars-devel] Review Request 119010: In C++, it should be std::isnan() from <cmath>

[Alexander Wolf]

> On June 29, 2014, 5:18 p.m., Alexander Wolf wrote:
> > Ship It!
> 
> Vadim Zhukov wrote:
>     Thank you for review. Could you, please, commit? I do not have commit rights.

Done.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119010/#review61162
-----------------------------------------------------------


On June 29, 2014, 5:15 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119010/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 5:15 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> KStars uses isnan() at a few places. Unfortunately, it uses isnan() from plain C that looks like picked up by accident on some systems (while it should not be, in general). This breaks compilation on other conformant systems, like OpenBSD, which try to not leak symbols without explicit request.
> 
> The right way is to use std::isnan() from <cmath>. It's already done in kstars/skyobjects/ksmoon.cpp, but few other files need fixing.
> 
> Please note that I do not have commit rights at KDE repos.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/asteroidscomponent.cpp e173145 
>   kstars/skycomponents/cometscomponent.cpp e3b6540 
>   kstars/skyobjects/starobject.cpp ca0400d 
> 
> Diff: https://git.reviewboard.kde.org/r/119010/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13 (the affected code wasn't changed in KStars master branch).
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140630/380b09a8/attachment.html>