[Kstars-devel] Review Request 115375: Added exit option in what's interesting

[Samikshan Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115375/#review48583
-----------------------------------------------------------


KStars fails to install with this patch as you haven't added the close.png file as a part of the patch.

-- Up-to-date: /NotBackedUp/kde/usr/share/apps/kstars/tools/whatsinteresting/qml/reloadIcon.png
-- Up-to-date: /NotBackedUp/kde/usr/share/apps/kstars/tools/whatsinteresting/qml/next.png
-- Up-to-date: /NotBackedUp/kde/usr/share/apps/kstars/tools/whatsinteresting/qml/previous.png
CMake Error at kstars/tools/whatsinteresting/qml/cmake_install.cmake:44 (FILE):
  file INSTALL cannot find
  "/NotBackedUp/kde/kstars/kstars/tools/whatsinteresting/qml/close.png".
Call Stack (most recent call first):
  kstars/cmake_install.cmake:210 (INCLUDE)
  cmake_install.cmake:38 (INCLUDE)


make: *** [install] Error 1



kstars/tools/whatsinteresting/wiview.h
<https://git.reviewboard.kde.org/r/115375/#comment34331>

    Remove the trailing whitespace occurances marked in red.


- Samikshan Bairagya


On Jan. 29, 2014, 10:05 a.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115375/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 10:05 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Added a exit option to exit kstars in what's interesting tool .
> 
> 
> Diffs
> -----
> 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt 790f0e9 
>   kstars/tools/whatsinteresting/qml/wiview.qml 47a15ff 
>   kstars/tools/whatsinteresting/wiview.h c02d689 
>   kstars/tools/whatsinteresting/wiview.cpp 6fcc3c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115375/diff/
> 
> 
> Testing
> -------
> 
> Yes,works fine .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140130/166b1de0/attachment.html>