[Kstars-devel] Review Request 112667: Add solar/lunar eclipse button to conjunction tool

[Henry de Valence]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/#review47425
-----------------------------------------------------------



kstars/tools/conjunctions.cpp
<https://git.reviewboard.kde.org/r/112667/#comment33731>

    What does eclipseType = -1 mean? Maybe eclipseType should be an enum, not an int.



kstars/tools/conjunctions.cpp
<https://git.reviewboard.kde.org/r/112667/#comment33729>

    Rather than a boolean, this should take an enum value, so that readers don't need to wonder whether 'true' means Lunar or Solar.



kstars/tools/conjunctions.cpp
<https://git.reviewboard.kde.org/r/112667/#comment33730>

    Where does 1.0 come from?


- Henry de Valence


On Jan. 14, 2014, 12:51 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112667/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 12:51 p.m.)
> 
> 
> Review request for KDE Edu, KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Add solar/lunar eclipse button to conjunctions tool for better usability 
> 
> 
> Diffs
> -----
> 
>   kstars/tools/conjunctions.h 2e37651 
>   kstars/tools/conjunctions.cpp 529f91d 
>   kstars/tools/conjunctions.ui d4c5138 
> 
> Diff: https://git.reviewboard.kde.org/r/112667/diff/
> 
> 
> Testing
> -------
> 
> Tested , it predicts correct dates of eclipse but some eclipse may not get displayed
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140115/2e64e626/attachment.html>