[Kstars-devel] Review Request 112667: Add solar/lunar eclipse button to conjunction tool

[Vijay Dhameliya]

> On Feb. 23, 2014, 5:01 p.m., Albert Astals Cid wrote:
> > I guess this needs fixing because of the discussion in the irc channel:
> > 
> > [22:49:32] <kstar> tsdgeos: Oh, I meant to tell you that I had some complaints with that.
> > [22:49:43] <kstar> tsdgeos: Including the fact that the lunar eclipse calculations are in principle incorrect.
> > [22:50:07] <kstar> tsdgeos: I'm sorry I cannot be active on KStars anymore. hdevalence seems to have more time than me these days.
> > [22:50:37] <kstar> vijay13: When you're computing a lunar eclipse, the diameter for the conjunction has to be the size of the umbra of the earth.
> > [22:50:44] <kstar> i.e. the angle subtended by the earth at the moon.
> > [22:51:23] <kstar> So you can calculate oppositions, but the tolerance must be (if I understand correctly), the diameter of the sun at the moon + the diameter of the earth at the moon or something like that.
> > [22:52:41] <vijay13> kstar: seems logical what you saying , I am ashamed of maself ;-) i just used shortway that time
> >

This patch is not more valid, since there is need to implement complete new logic to calculate lunar eclipse so I am closing this review request. 


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/#review50598
-----------------------------------------------------------


On Feb. 23, 2014, 6:06 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112667/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 6:06 p.m.)
> 
> 
> Review request for KDE Edu, KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Add solar/lunar eclipse button to conjunctions tool for better usability 
> 
> 
> Diffs
> -----
> 
>   kstars/tools/conjunctions.h 2e37651 
>   kstars/tools/conjunctions.cpp 529f91d 
>   kstars/tools/conjunctions.ui d4c5138 
> 
> Diff: https://git.reviewboard.kde.org/r/112667/diff/
> 
> 
> Testing
> -------
> 
> Tested , it predicts correct dates of eclipse but some eclipse may not get displayed
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140223/ee45321f/attachment.html>