[Kstars-devel] Review Request 115375: Added exit option in what's interesting

[Samikshan Bairagya]

> On Jan. 30, 2014, 5:33 a.m., Samikshan Bairagya wrote:
> > kstars/tools/whatsinteresting/wiview.h, line 113
> > <https://git.reviewboard.kde.org/r/115375/diff/1/?file=240949#file240949line113>
> >
> >     Remove the trailing whitespace occurances marked in red.
> 
> Heena Mahour wrote:
>     done.

Thanks. But regarding the close.png icon, you need to include it in the diff itself, not as a separate attachment.


- Samikshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115375/#review48583
-----------------------------------------------------------


On Jan. 31, 2014, 2:31 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115375/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 2:31 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Added a exit option to exit kstars in what's interesting tool .
> 
> 
> Diffs
> -----
> 
>   kstars/tools/whatsinteresting/wiview.cpp 6fcc3c3 
>   kstars/tools/whatsinteresting/wiview.h c02d689 
>   kstars/tools/whatsinteresting/qml/wiview.qml 47a15ff 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt 790f0e9 
> 
> Diff: https://git.reviewboard.kde.org/r/115375/diff/
> 
> 
> Testing
> -------
> 
> Yes,works fine .
> 
> 
> File Attachments
> ----------------
> 
> close.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/54f19a47-c89d-4417-acda-a6b26e822256__close.png
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140205/4b03717d/attachment.html>