[Kstars-devel] Review Request 115705: Made keyword wikipedia in "What's interesting..." clickable so Wikipedia link opens in browser when clicked

[Vijay Dhameliya]

> On April 13, 2014, 9:46 a.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/skyobjdescription.cpp, line 48
> > <https://git.reviewboard.kde.org/r/115705/diff/4/?file=265030#file265030line48>
> >
> >     Inconsistent formatting.

Actually, I have no idea how would the following be formatted:

 int startIndex = data.lastIndexOf( urlOpening ) + urlOpening.length();


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115705/#review55567
-----------------------------------------------------------


On April 12, 2014, 10:11 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115705/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 10:11 p.m.)
> 
> 
> Review request for KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> The Wikipedia link for skyobject will be retrieved from data received by Wikipedia API and it is being passed to QML so that when user clicks on source in "What's Interesting..." UI it will be open in browser.
> 
> 
> Diffs
> -----
> 
>   kstars/tools/whatsinteresting/qml/wiview.qml 47a15ff 
>   kstars/tools/whatsinteresting/skyobjdescription.h d909fa1 
>   kstars/tools/whatsinteresting/skyobjdescription.cpp 2b83155 
>   kstars/tools/whatsinteresting/skyobjitem.cpp a397c1a 
> 
> Diff: https://git.reviewboard.kde.org/r/115705/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140413/d54915f0/attachment.html>