[Kstars-devel] Review Request 116965: Added exponential zoom in/out feature in Solar System Viewer

Rafal Kulaga rl.kulaga at gmail.com
Sat Apr 12 19:22:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116965/#review55537
-----------------------------------------------------------



kstars/tools/pvplotwidget.cpp
<https://git.reviewboard.kde.org/r/116965/#comment38641>

    I hate to point this out again, but please make your formatting( consistent ) ;-) After that, you can push your changes to the master and mark this RR as submitted.


- Rafal Kulaga


On April 12, 2014, 6:57 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116965/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 6:57 p.m.)
> 
> 
> Review request for KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Currently zoom in/out factor is set constant which is very small so zoom in/out works very slowly, i.e. user have to keep rolling mouse wheel for long to get zoom enough to observe single planet. 
> 
> This features allows user to do quick zoom in/out by pressing ctrl + wheel/+-keys. 
> 
> 
> Diffs
> -----
> 
>   kstars/tools/pvplotwidget.h ef90ace 
>   kstars/tools/pvplotwidget.cpp b8a8b30 
> 
> Diff: https://git.reviewboard.kde.org/r/116965/diff/
> 
> 
> Testing
> -------
> 
> Testing has done for following use cases:
> 1) Zoom in/out by pressing +/- continuously till it can not zoom in/out furthermore 
> 2) Zoom in/out by rolling rolling wheel up/down continuously till it can not zoom in/out furthermore 
> 3) Zoom in/out by pressing Ctrl + +/- continuously till it can not zoom in/out furthermore 
> 4) Zoom in/out by rolling Ctrl + rolling wheel up/down continuously till it can not zoom in/out furthermore 
> 5) Zoom in/out by pressing +/- step by step till it can not zoom in/out furthermore 
> 6) Zoom in/out by rolling rolling wheel up/down step by step till it can not zoom in/out furthermore 
> 7) Zoom in/out by pressing Ctrl + +/- step by step till it can not zoom in/out furthermore 
> 8) Zoom in/out by rolling Ctrl + rolling wheel up/down step by step till it can not zoom in/out furthermore
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140412/61f22335/attachment.html>


More information about the Kstars-devel mailing list