[Kstars-devel] Review Request 115705: Made keyword wikipedia in "What's interesting..." clickable so Wikipedia link opens in browser when clicked

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115705/#review55529
-----------------------------------------------------------



kstars/tools/whatsinteresting/skyobjdescription.cpp
<https://git.reviewboard.kde.org/r/115705/#comment38639>

    Typo: description



kstars/tools/whatsinteresting/skyobjdescription.cpp
<https://git.reviewboard.kde.org/r/115705/#comment38638>

    Typo: received



kstars/tools/whatsinteresting/skyobjdescription.cpp
<https://git.reviewboard.kde.org/r/115705/#comment38640>

    Why not put those opening and closing tag strings in constant QString objects. It would be more elegant. Also, try to avoid adding such magic numbers like this 26.


- Rafal Kulaga


On Feb. 12, 2014, 9:42 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115705/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 9:42 p.m.)
> 
> 
> Review request for KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> The Wikipedia link for skyobject will be retrieved from data received by Wikipedia API and it is being passed to QML so that when user clicks on source in "What's Interesting..." UI it will be open in browser.
> 
> 
> Diffs
> -----
> 
>   kstars/tools/whatsinteresting/qml/wiview.qml 47a15ff 
>   kstars/tools/whatsinteresting/skyobjdescription.h d909fa1 
>   kstars/tools/whatsinteresting/skyobjdescription.cpp 2b83155 
>   kstars/tools/whatsinteresting/skyobjitem.cpp a397c1a 
> 
> Diff: https://git.reviewboard.kde.org/r/115705/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140412/b9a86f79/attachment-0001.html>