[Kstars-devel] Review Request 116965: Added exponential zoom in/out feature in Solar System Viewer

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116965/#review55164
-----------------------------------------------------------



kstars/tools/pvplotwidget.cpp
<https://git.reviewboard.kde.org/r/116965/#comment38454>

    Please be consistent in code formatting: this->magFactor( e->modifiers() );



kstars/tools/pvplotwidget.cpp
<https://git.reviewboard.kde.org/r/116965/#comment38455>

    Again, code formatting:
    
    factor * 0.01 * size 
    
    etc.



kstars/tools/pvplotwidget.cpp
<https://git.reviewboard.kde.org/r/116965/#comment38456>

    Same here.



kstars/tools/pvplotwidget.cpp
<https://git.reviewboard.kde.org/r/116965/#comment38457>

    Also here...



kstars/tools/pvplotwidget.cpp
<https://git.reviewboard.kde.org/r/116965/#comment38458>

    ... and here.


Apart from that, it would be nice if those two zoom in/out buttons were working in coarse mode.

- Rafal Kulaga


On April 7, 2014, 1:06 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116965/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 1:06 p.m.)
> 
> 
> Review request for KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Currently zoom in/out factor is set constant which is very small so zoom in/out works very slowly, i.e. user have to keep rolling mouse wheel for long to get zoom enough to observe single planet. 
> 
> This features allows user to do quick zoom in/out by pressing ctrl + wheel/+-keys. 
> 
> 
> Diffs
> -----
> 
>   kstars/tools/pvplotwidget.h ef90ace 
>   kstars/tools/pvplotwidget.cpp b8a8b30 
> 
> Diff: https://git.reviewboard.kde.org/r/116965/diff/
> 
> 
> Testing
> -------
> 
> Testing has done for following use cases:
> 1) Zoom in/out by pressing +/- continuously till it can not zoom in/out furthermore 
> 2) Zoom in/out by rolling rolling wheel up/down continuously till it can not zoom in/out furthermore 
> 3) Zoom in/out by pressing Ctrl + +/- continuously till it can not zoom in/out furthermore 
> 4) Zoom in/out by rolling Ctrl + rolling wheel up/down continuously till it can not zoom in/out furthermore 
> 5) Zoom in/out by pressing +/- step by step till it can not zoom in/out furthermore 
> 6) Zoom in/out by rolling rolling wheel up/down step by step till it can not zoom in/out furthermore 
> 7) Zoom in/out by pressing Ctrl + +/- step by step till it can not zoom in/out furthermore 
> 8) Zoom in/out by rolling Ctrl + rolling wheel up/down step by step till it can not zoom in/out furthermore
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140407/9b055c1f/attachment-0001.html>