[Kstars-devel] Review Request 112879: Restring addition of null supernovae objects to supernovaecomponent list

[Henry de Valence]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112879/#review41011
-----------------------------------------------------------

Ship it!


In that case, this looks good. Thanks for taking the time to track down the root cause of the bug.

- Henry de Valence


On Sept. 29, 2013, 6:19 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112879/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 6:19 a.m.)
> 
> 
> Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Bugs: 322848
>     http://bugs.kde.org/show_bug.cgi?id=322848
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> While loading data for supernovae, there seems error in reading file supernovae.dat  so it leads to creation of dummy supernovae object which leads to various error during run time of Kstars. So lets avoid creation of such dummy supernovae objects. 
> This fixes attached bug too.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/supernovaecomponent.cpp 166a3d5 
> 
> Diff: http://git.reviewboard.kde.org/r/112879/diff/
> 
> 
> Testing
> -------
> 
> Tested - Runs well
> Bug resolved permanently 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130929/20ef9093/attachment.html>