[Kstars-devel] Review Request 112726: Ordered visibility check for first point of SkyPolyLine in drawSkyPolyline function

Vijay Dhameliya vijay.atwork13 at gmail.com
Sun Sep 29 06:27:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112726/
-----------------------------------------------------------

(Updated Sept. 29, 2013, 6:27 a.m.)


Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.


Summary (updated)
-----------------

Ordered visibility check for first point of SkyPolyLine in drawSkyPolyline function 


Description
-------

Variable isVisibleLast and isVisible are not initialized so stores random value while operated and with check visibility and correct visibility of point are stored in same variable when passed to toScreen function.  


This addresses bug 303547.
    http://bugs.kde.org/show_bug.cgi?id=303547


Diffs
-----

  kstars/skyqpainter.cpp b53b76c 

Diff: http://git.reviewboard.kde.org/r/112726/diff/


Testing
-------

Tested 
Lines on display appears correctly 


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130929/378ff51f/attachment.html>


More information about the Kstars-devel mailing list