[Kstars-devel] Review Request 112879: Setting altitude and azimuth to default in skypoint when not set from catalog

[Vijay Dhameliya]

> On Sept. 22, 2013, 10:04 p.m., Akarsh Simha wrote:
> > Please set them to NaN if that works well.
> > It is better to report an NaN, then a number that is wrong / fake.
> 
> Rafal Kulaga wrote:
>     NaNs were the values that caused those crashes, due to failed assertions at the line 349 in skypoint.cpp. The cleanest fix to this will be to handle those NaNs in a different way - e.g. just check for them at the beginning of appropriate functions.
>     
>     Three notes: 1) std::isfinite() will return false for NaN value, 2) Q_ASSERT will only cause the application to terminate if it was built in debug mode, 3) We're not actually fixing any problems visible to user with such solution.

That was my incredible foolishness but simply returning from function without going into further calculation is better idea I guess.  


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112879/#review40489
-----------------------------------------------------------


On Sept. 23, 2013, 2:20 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112879/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 2:20 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rafal Kulaga.
> 
> 
> Description
> -------
> 
> If Alt/Az or RA/Dec are not finite before using them in further calculation in HorizontalToEquatorial and nutate method then it leads to error in further calculation. 
> 
> 
> This addresses bug 322848.
>     http://bugs.kde.org/show_bug.cgi?id=322848
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/skypoint.cpp f634075 
> 
> Diff: http://git.reviewboard.kde.org/r/112879/diff/
> 
> 
> Testing
> -------
> 
> Tested - Runs well
> Bug resolved permanently 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130923/38aa1a1c/attachment.html>