[Kstars-devel] Review Request 112732: Stop unnecessary iteration when null name is passed to getImage

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112732/#review40491
-----------------------------------------------------------

Ship it!


+1 for this change. You can also use QString::isEmpty().

- Rafal Kulaga


On Sept. 15, 2013, 4:58 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112732/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 4:58 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rafal Kulaga.
> 
> 
> Description
> -------
> 
> When null string is passed as name to getImage function of TextureManager ,there is no need to call TextureManager::findTexture() and can return empyImage directly. 
> 
> 
> Diffs
> -----
> 
>   kstars/texturemanager.cpp 33df367 
> 
> Diff: http://git.reviewboard.kde.org/r/112732/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130922/65c04cd4/attachment.html>