[Kstars-devel] Review Request 112879: Setting altitude and azimuth to default in skypoint when not set from catalog

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112879/#review40488
-----------------------------------------------------------


This will indeed prevent some problems from becoming visible, but I was wondering if it wouldn't be a better idea to just return from those functions? After all, there is no point in performing all the remaining computations, as the point's data is already clearly invalid.

- Rafal Kulaga


On Sept. 22, 2013, 8:22 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112879/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2013, 8:22 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rafal Kulaga.
> 
> 
> Description
> -------
> 
> If Alt/Az or RA/Dec are not finite before using them in further calculation in HorizontalToEquatorial and nutate method then it leads to error in further calculation. 
> 
> 
> This addresses bug 322848.
>     http://bugs.kde.org/show_bug.cgi?id=322848
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/skypoint.cpp f634075 
> 
> Diff: http://git.reviewboard.kde.org/r/112879/diff/
> 
> 
> Testing
> -------
> 
> Tested - Runs well
> Bug resolved permanently 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130922/0aab8ab7/attachment.html>