[Kstars-devel] Review Request 112720: Removing repeated check for height and width of image under getDSSURL functions and making observation list table resizable to user

[Akarsh Simha]

> On Sept. 14, 2013, 10:27 p.m., Akarsh Simha wrote:
> > There is a problem with this change:
> > 
> > I think getDSSURL() is also called elsewhere where it is desirable to allow width and height to be smaller than dss_default_size (for example, it could be called via DBus). Ideally, it should not be confined to be larger than dss_default_size if called outside of KStars.
> 
> Rafal Kulaga wrote:
>     You're obviously right. Anyway, those two ifs can and should be combined.

Yeah, I guess this patch should be shipped because it makes the code cleaner. If I ever notice that something is not working as expected because of this change, and the only way is to let getDSSURL() be a little dumber, I'll go back and change things. But this is cleaner, and I agree it should be okay to commit it.


- Akarsh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112720/#review40035
-----------------------------------------------------------


On Sept. 14, 2013, 11:20 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112720/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2013, 11:20 p.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rishab Arora.
> 
> 
> Description
> -------
> 
> Height and width of image are being checked twice for same validity under getDSSURL function so first check is removed. 
> Making Wish list and Session plan table column under Observation list resizable by user for better usability.    
> 
> 
> Diffs
> -----
> 
>   kstars/ksutils.cpp d517deb 
>   kstars/tools/observinglist.cpp 7eb5ab5 
> 
> Diff: http://git.reviewboard.kde.org/r/112720/diff/
> 
> 
> Testing
> -------
> 
> Runs correctly 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130914/f27dee8b/attachment.html>