[Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and default width of column is set larger

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112496/#review40031
-----------------------------------------------------------


Comments below. With this configuration of the view, it is not possible to change the width of the "Object 2" section - this should be fixed.


kstars/tools/conjunctions.h
<http://git.reviewboard.kde.org/r/112496/#comment29634>

    Please use const references and fix whitespaces.



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29635>

    I wonder if "Date & Time" wouldn't be better...



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29636>

    Again, WS fix and const references please.



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29637>

    Stray WS.



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/112496/#comment29638>

    Stray WS


- Rafal Kulaga


On Sept. 13, 2013, 10:56 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112496/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:56 p.m.)
> 
> 
> Review request for KStars and Akarsh Simha.
> 
> 
> Description
> -------
> 
> In conjunctions tool default width of column in text box is set large enough to make it look better and column "object 2" is added to keep log of to which object the object 1 is mapping,  when we have calculated many conjunctions from same object 1 to different object 2s.
> 
> 
> Diffs
> -----
> 
>   kstars/tools/conjunctions.cpp 39cef00 
>   kstars/tools/conjunctions.h b51209e 
>   kstars/tools/conjunctions.ui 80374b1 
> 
> Diff: http://git.reviewboard.kde.org/r/112496/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130914/3e730ea8/attachment-0001.html>