[Kstars-devel] Review Request 112720: Removing repeated check for height and width of image under getDSSURL functions and making observation list table resizable to user

[Vijay Dhameliya]

> On Sept. 13, 2013, 10:17 p.m., Rafal Kulaga wrote:
> > kstars/tools/observinglist.cpp, line 127
> > <http://git.reviewboard.kde.org/r/112720/diff/1/?file=189388#file189388line127>
> >
> >     I am not sure if I understand what you want to achieve by passing QHeaderView::ResizeToContents as a section argument for this call. Could you please explain that?
> 
> Vijay Dhameliya wrote:
>     Passing second argument allows user to change the width of column in case name of object is longer and user wants to read it, currently it doesnt allow user to change width of any column.
> 
> Rafal Kulaga wrote:
>     I get it, but take a look at this - http://qt-project.org/doc/qt-4.8/qheaderview.html#setResizeMode-2
>     
>     What you're doing is using enum type value (QHeaderView::ResizeToContents - 3) to specify a section. The problem is that this type has nothing to do with the section index, so it's confusing.

Sorry I misunderstood it, thank you. 


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112720/#review39999
-----------------------------------------------------------


On Sept. 13, 2013, 11:07 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112720/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 11:07 p.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rishab Arora.
> 
> 
> Description
> -------
> 
> Height and width of image are being checked twice for same validity under getDSSURL function so first check is removed. 
> Making Wish list and Session plan table column under Observation list resizable by user for better usability.    
> 
> 
> Diffs
> -----
> 
>   kstars/ksutils.cpp d517deb 
> 
> Diff: http://git.reviewboard.kde.org/r/112720/diff/
> 
> 
> Testing
> -------
> 
> Runs correctly 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130913/095a20f7/attachment.html>