[Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw()

[Vijay Dhameliya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113438/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 12:14 p.m.)


Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.


Bugs: 326647
    http://bugs.kde.org/show_bug.cgi?id=326647


Repository: kstars


Description
-------

Bug:
->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
 
Fixing:
-> Drawing KSComet on the basis of Total Magnitude Parameter


Diffs (updated)
-----

  kstars/dialogs/detaildialog.cpp efda624 
  kstars/skycomponents/cometscomponent.cpp 395c856 

Diff: http://git.reviewboard.kde.org/r/113438/diff/


Testing
-------

Bug fixed - No more crashing 


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131028/45c0aea1/attachment.html>