[Kstars-devel] Review Request 113325: Calling findMagnitude() from DetailDialog via public function updateMag()

[Henry de Valence]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113325/#review42508
-----------------------------------------------------------



kstars/dialogs/detaildialog.cpp
<http://git.reviewboard.kde.org/r/113325/#comment30828>

    Typo: this should be updateMag



kstars/skyobjects/ksmoon.cpp
<http://git.reviewboard.kde.org/r/113325/#comment30829>

    It would be better to just do:
    
    // findMagnitude() for Saturn needs a KSNumbers, and we use the same signature.
    findMagnitude(NULL);
    


- Henry de Valence


On Oct. 19, 2013, 12:27 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113325/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2013, 12:27 p.m.)
> 
> 
> Review request for KStars, Akarsh Simha, Rafal Kulaga, and Rishab Arora.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Strange thing is findMagnitude() function from moon object is never called in Kstars even though its implementation is correct and yields correct magnitude of moon according to wikipedia. 
> The public method updateMag() can be called from anywhere in Kstars to set magnitude in Moon object and it is called from class DetailDialog to saw magnitude in detail dialog widget. 
> Many skyobject like Saturn and some stars the magnitude is always in hundredth decimal place so it is better to set magnitude to hundredth decimal place in class DetailDialog. 
> 
> 
> Diffs
> -----
> 
>   kstars/dialogs/detaildialog.cpp efda624 
>   kstars/skyobjects/ksmoon.h 559d203 
>   kstars/skyobjects/ksmoon.cpp ac7e4ed 
> 
> Diff: http://git.reviewboard.kde.org/r/113325/diff/
> 
> 
> Testing
> -------
> 
> Integer digits of magnitude being calculated matches to that given on Wikipedia for all phases 
> 
> 
> File Attachments
> ----------------
> 
> moon_detail_before.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/e2e4721f-607b-40c4-b3aa-f2787002a873__moon_detail_before.png
> moon_detail_after.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/13d80941-59f1-4ab5-83f4-858153f3263a__moon_detail_after.png
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131028/1849fedc/attachment.html>