[Kstars-devel] Review Request 112726: Ordered visibility check for first point of SkyPolyLine in drawSkyPolyline function

Commit Hook null at kde.org
Fri Oct 18 13:55:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112726/#review41944
-----------------------------------------------------------


This review has been submitted with commit 37bc667dbdaee94af87d44c2493620db5f31644a by Albert Astals Cid on behalf of Vijay Dhameliya to branch KDE/4.11.

- Commit Hook


On Sept. 29, 2013, 6:27 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112726/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 6:27 a.m.)
> 
> 
> Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Bugs: 303547
>     http://bugs.kde.org/show_bug.cgi?id=303547
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Variable isVisibleLast and isVisible are not initialized so stores random value while operated and with check visibility and correct visibility of point are stored in same variable when passed to toScreen function.  
> 
> 
> Diffs
> -----
> 
>   kstars/skyqpainter.cpp b53b76c 
> 
> Diff: http://git.reviewboard.kde.org/r/112726/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> Lines on display appears correctly 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131018/4efa9bab/attachment-0001.html>


More information about the Kstars-devel mailing list