[Kstars-devel] Review Request 112732: Stop unnecessary iteration when null name is passed to getImage

Vijay Dhameliya vijay.atwork13 at gmail.com
Fri Oct 18 13:52:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112732/
-----------------------------------------------------------

(Updated Oct. 18, 2013, 1:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for KStars, Akarsh Simha and Rafal Kulaga.


Repository: kstars


Description
-------

When null string is passed as name to getImage function of TextureManager ,there is no need to call TextureManager::findTexture() and can return empyImage directly. 


Diffs
-----

  kstars/texturemanager.cpp 33df367 

Diff: http://git.reviewboard.kde.org/r/112732/diff/


Testing
-------


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131018/4d037edb/attachment.html>


More information about the Kstars-devel mailing list