[Kstars-devel] Review Request 112879: Restring addition of null supernovae objects to supernovaecomponent list

Commit Hook null at kde.org
Fri Oct 18 13:47:19 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112879/#review41942
-----------------------------------------------------------


This review has been submitted with commit 65e57507b6acd1fc9290b3d6455bf9d25ef5d53f by Albert Astals Cid on behalf of Vijay Dhameliya to branch KDE/4.11.

- Commit Hook


On Sept. 29, 2013, 6:19 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112879/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 6:19 a.m.)
> 
> 
> Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Bugs: 322848
>     http://bugs.kde.org/show_bug.cgi?id=322848
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> While loading data for supernovae, there seems error in reading file supernovae.dat  so it leads to creation of dummy supernovae object which leads to various error during run time of Kstars. So lets avoid creation of such dummy supernovae objects. 
> This fixes attached bug too.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/supernovaecomponent.cpp 166a3d5 
> 
> Diff: http://git.reviewboard.kde.org/r/112879/diff/
> 
> 
> Testing
> -------
> 
> Tested - Runs well
> Bug resolved permanently 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131018/81664976/attachment.html>


More information about the Kstars-devel mailing list